Bug 253904 - [Darwin] Call `sys_icache_invalidate()` directly in `ARM64Assembler::flushCache()`
Summary: [Darwin] Call `sys_icache_invalidate()` directly in `ARM64Assembler::flushCac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-14 13:53 PDT by Chris Dumez
Modified: 2023-03-14 17:17 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-14 13:53:08 PDT 
Call `sys_icache_invalidate()` directly in `ARM64Assembler::flushCache()`. Previously, we'd call `sys_cache_control(kCacheFunctionPrepareForExecution)`, which would have to do a switch on its parameter before calling `sys_icache_invalidate()`.
Comment 1 EWS 2023-03-14 17:16:32 PDT 
Committed 261661@main (2cc0a6b10cf0): <https://commits.webkit.org/261661@main>

Reviewed commits have been landed. Closing PR #11512 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-03-14 17:17:20 PDT 
<rdar://problem/106728867>