Bug 253927 - ReleaseSerializedImageBuffer doesn't release the underlying IOSurface
Summary: ReleaseSerializedImageBuffer doesn't release the underlying IOSurface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
: 254974 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-14 19:05 PDT by Matt Woodrow
Modified: 2023-04-06 11:07 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-03-14 19:05:43 PDT 
We're adding a read reference in the RemoteSerializedImageBufferProxy constructor, and we never have any reads happen if we destroy the RemoteSerializedImageBufferProxy without transferring to an ImageBuffer.

This shouldn't happen often, but can happen if you draw to an OffscreenCanvas, call `commit()`, and then draw again quickly (not waiting for rAF).
Comment 1 Matt Woodrow 2023-03-14 19:08:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11534
Comment 2 EWS 2023-03-15 12:15:48 PDT 
Committed 261703@main (284c71ac630f): <https://commits.webkit.org/261703@main>

Reviewed commits have been landed. Closing PR #11534 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-15 12:16:16 PDT 
<rdar://problem/106767160>
Comment 4 Matt Woodrow 2023-04-06 11:07:37 PDT 
*** Bug 254974 has been marked as a duplicate of this bug. ***