Bug 253933 - Correct RenderListMarker::styleDidChange check for list-style-type after 261651@main
Summary: Correct RenderListMarker::styleDidChange check for list-style-type after 2616...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-14 22:14 PDT by Tim Nguyen (:ntim)
Modified: 2023-03-14 22:38 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-03-14 22:14:41 PDT 
The new check in 261651@main is incorrect, we can simply remove the `style().listStyleType().type == ListStyleType::Type::String` part.

The `style().listStyleType() != oldStyle->listStyleType()` now covers the string case too, since ListStyleType's equality operator checks both the identifier and the type.
Comment 1 Radar WebKit Bug Importer 2023-03-14 22:14:59 PDT 
<rdar://problem/106737094>
Comment 2 Tim Nguyen (:ntim) 2023-03-14 22:16:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11539
Comment 3 EWS 2023-03-14 22:38:41 PDT 
Committed 261675@main (2d0106d057af): <https://commits.webkit.org/261675@main>

Reviewed commits have been landed. Closing PR #11539 and removing active labels.