Bug 253996 - [ManagedMSE] network transfer should be tagged as media between startstreaming/endstreaming events
Summary: [ManagedMSE] network transfer should be tagged as media between startstreamin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-15 18:12 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-03-19 18:43 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-03-15 18:12:54 PDT 
In bug 249569; we notified the Network Process that network transfer should be tagged as media whenever a MediaSource object was attached to a media element.

A side effect is that all transfers would be tagged as media streaming for the entire lifetime of the MediaSource object.

ManagedMediaSource gives us greater granularity is that we only allow data to be appended to the ManagedSourceBuffer when ManagedMediaSource.streaming is true.

We should only tag traffic as media when ManagedSourceBuffer.streaming is true (which is true between the events startstreaming and endstreaming)
Comment 1 Radar WebKit Bug Importer 2023-03-15 18:13:16 PDT 
<rdar://problem/106783581>
Comment 2 Jean-Yves Avenard [:jya] 2023-03-18 23:23:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11693
Comment 3 EWS 2023-03-19 18:43:19 PDT 
Committed 261850@main (d55ce0bd5ffa): <https://commits.webkit.org/261850@main>

Reviewed commits have been landed. Closing PR #11693 and removing active labels.