Bug 254000 - In results.html, match-ref test links to expected images have an extra dot between the filename and the extension
Summary: In results.html, match-ref test links to expected images have an extra dot be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gerald Squelart
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-15 19:14 PDT by Gerald Squelart
Modified: 2023-03-17 06:02 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Squelart 2023-03-15 19:14:23 PDT
The problem is visible in rdar://100336472 , where the results page shows "ref mismatch" but the URL contains an extra dot: `[...]attachment-wrapping-action-expected-mismatch..html`, making it impossible to view the image.
The code in results.html's imageResultLinks looks like:
>            let testExtension = Utils.splitExtension(testResult.name)[1];
...
>                result += TestResultsController.resultLink(this._resultsController.layoutTestsBasePath() + testPrefix, '-expected-mismatch.' + testExtension, 'ref mismatch');
...
>                    result += TestResultsController.resultLink(this._resultsController.layoutTestsBasePath() + testPrefix, '-expected.' + testExtension, 'reference');

The `testExtension` variable contains ".html", so we don't need to add one before.

<rdar://106785429>
Comment 1 Gerald Squelart 2023-03-15 19:17:34 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11589
Comment 2 EWS 2023-03-17 06:02:08 PDT
Committed 261791@main (9872023d5aed): <https://commits.webkit.org/261791@main>

Reviewed commits have been landed. Closing PR #11589 and removing active labels.