Bug 254097 - Have SourceBufferPrivate::m_buffered be a Ref<TimeRanges>
Summary: Have SourceBufferPrivate::m_buffered be a Ref<TimeRanges>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-17 18:32 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-03-18 16:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-03-17 18:32:04 PDT 
And have have SourceBufferPrivate::buffered() return a reference as it can never be null
Comment 1 Radar WebKit Bug Importer 2023-03-17 18:32:32 PDT 
<rdar://problem/106883787>
Comment 2 Jean-Yves Avenard [:jya] 2023-03-18 00:07:21 PDT 
Actually, SourceBufferPrivate::m_buffered should be a PlatformTimeRanges instead as using a TimeRanges there is a layering violation
Comment 3 Jean-Yves Avenard [:jya] 2023-03-18 01:16:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11679
Comment 4 EWS 2023-03-18 16:24:56 PDT 
Committed 261829@main (e99dba48f4a7): <https://commits.webkit.org/261829@main>

Reviewed commits have been landed. Closing PR #11679 and removing active labels.