Bug 254139 - [WinCairo] does not compile with TOUCH_EVENTS
Summary: [WinCairo] does not compile with TOUCH_EVENTS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-19 12:36 PDT by Max Schmitt
Modified: 2023-03-19 14:39 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Schmitt 2023-03-19 12:36:50 PDT 
C:\Users\maxschmitt\webkit\Source\WebKit\Shared\win\WebEventFactory.cpp(477): error C4430: missing type specifier - int assumed. Note: C++ does not support default
-int
C:\Users\maxschmitt\webkit\Source\WebKit\Shared\win\WebEventFactory.cpp(477): error C2143: syntax error: missing ',' before '*'
C:\Users\maxschmitt\webkit\Source\WebKit\Shared\win\WebEventFactory.cpp(477): error C2511: 'WebKit::WebTouchEvent WebKit::WebEventFactory::createWebTouchEvent(cons
t int)': overloaded member function not found in 'WebKit::WebEventFactory'
C:\Users\maxschmitt\webkit\Source\WebKit\Shared\win\WebEventFactory.h(41): note: see declaration of 'WebKit::WebEventFactory'

and

WebPopupMenuProxyWin.cpp.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl WebCore::ScrollableArea::handleTouchEvent(class WebCore::Pla
tformTouchEvent const &)" (?handleTouchEvent@ScrollableArea@WebCore@@UEAA_NAEBVPlatformTouchEvent@2@@Z)
Comment 1 Max Schmitt 2023-03-19 12:40:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11698
Comment 2 EWS 2023-03-19 14:38:19 PDT 
Committed 261844@main (283c8109d448): <https://commits.webkit.org/261844@main>

Reviewed commits have been landed. Closing PR #11698 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-19 14:39:18 PDT 
<rdar://problem/106920403>