RESOLVED FIXED254154
[IFC][Partial layout] Fix http/tests/security/cross-origin-cached-images-with-memory-pressure.html 
https://bugs.webkit.org/show_bug.cgi?id=254154
Summary [IFC][Partial layout] Fix http/tests/security/cross-origin-cached-images-with...
alan
Reported 2023-03-20 06:52:03 PDT
ssia
Attachments
Patch (4.00 KB, patch)
2023-03-20 06:56 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (6.07 KB, patch)
2023-03-20 08:20 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-03-20 06:56:43 PDT
Created attachment 465518 [details] Patch
Antti Koivisto
Comment 2 2023-03-20 07:15:18 PDT
Comment on attachment 465518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465518&action=review > Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:318 > + if (m_inlineItems.isEmpty()) { > + // We must be under memory pressure. > + updateInlineDamage(InlineDamage::Type::Invalid, { }); > + return; > + } Maybe these could be factored into a function if (!canUsePartialInvalidation()) return;
Antti Koivisto
Comment 3 2023-03-20 07:18:41 PDT
if (setFullDamageIfNeeded()) return; or something.
alan
Comment 4 2023-03-20 07:23:43 PDT
(In reply to Antti Koivisto from comment #3) > if (setFullDamageIfNeeded()) > return; > > or something. good idea! Will do.
alan
Comment 5 2023-03-20 08:20:47 PDT
Created attachment 465520 [details] Patch
EWS
Comment 6 2023-03-20 15:41:32 PDT
Committed 261892@main (01f5eadff3e2): <https://commits.webkit.org/261892@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465520 [details].
Radar WebKit Bug Importer
Comment 7 2023-03-20 15:42:16 PDT
<rdar://problem/106965963>
Note You need to log in before you can comment on or make changes to this bug.