Bug 254154 - [IFC][Partial layout] Fix http/tests/security/cross-origin-cached-images-with-memory-pressure.html
Summary: [IFC][Partial layout] Fix http/tests/security/cross-origin-cached-images-with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-20 06:52 PDT by zalan
Modified: 2023-03-20 15:42 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.00 KB, patch)
2023-03-20 06:56 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.07 KB, patch)
2023-03-20 08:20 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-03-20 06:52:03 PDT
ssia
Comment 1 zalan 2023-03-20 06:56:43 PDT
Created attachment 465518 [details]
Patch
Comment 2 Antti Koivisto 2023-03-20 07:15:18 PDT
Comment on attachment 465518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465518&action=review

> Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:318
> +    if (m_inlineItems.isEmpty()) {
> +        // We must be under memory pressure.
> +        updateInlineDamage(InlineDamage::Type::Invalid, { });
> +        return;
> +    }

Maybe these could be factored into a function

if (!canUsePartialInvalidation()) 
    return;
Comment 3 Antti Koivisto 2023-03-20 07:18:41 PDT
if (setFullDamageIfNeeded())
    return;

or something.
Comment 4 zalan 2023-03-20 07:23:43 PDT
(In reply to Antti Koivisto from comment #3)
> if (setFullDamageIfNeeded())
>     return;
> 
> or something.

good idea! Will do.
Comment 5 zalan 2023-03-20 08:20:47 PDT
Created attachment 465520 [details]
Patch
Comment 6 EWS 2023-03-20 15:41:32 PDT
Committed 261892@main (01f5eadff3e2): <https://commits.webkit.org/261892@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465520 [details].
Comment 7 Radar WebKit Bug Importer 2023-03-20 15:42:16 PDT
<rdar://problem/106965963>