WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
254158
httpHeaderField always returns string
https://bugs.webkit.org/show_bug.cgi?id=254158
Summary
httpHeaderField always returns string
Anne van Kesteren
Reported
2023-03-20 08:31:56 PDT
This makes it impossible to distinguish between a missing header and a header that is present whose value is the empty string. It would be better if we were precise about this as Fetch and HTTP are too.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-20 08:32:05 PDT
<
rdar://problem/106944735
>
Chris Dumez
Comment 2
2023-03-20 08:35:08 PDT
String has a null state in WebKit. This should be distinguishable already. `string.isNull()` -> header is missing. `string.isEmpty() && !string.isNull()` -> header is present but has no value.
Chris Dumez
Comment 3
2023-03-20 08:35:32 PDT
I suggest we mark this bug as invalid unless I missed something.
Chris Dumez
Comment 4
2023-03-20 08:39:21 PDT
You could also use `httpHeaderFields().contains()`.
youenn fablet
Comment 5
2023-03-20 08:48:41 PDT
The bug is more that, apparently, some code paths are using isEmpty() while they should probably use isNull().
Anne van Kesteren
Comment 6
2023-03-20 09:04:17 PDT
Ah, I didn't realize that! Let's close this as INVALID then. I'll follow-up with more detailed bugs as I come across things.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug