RESOLVED FIXED254161
[pre-push] Handle 'None' commits 
https://bugs.webkit.org/show_bug.cgi?id=254161
Summary [pre-push] Handle 'None' commits
Jonathan Bedard
Reported 2023-03-20 09:55:16 PDT
`subprocess.run` does not handle 'None' arguments, so all of our '_for(commit)' functions in our pre-push hooks should return None if the commit argument provided is None.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-20 09:55:30 PDT
<rdar://problem/106949161>
Jonathan Bedard
Comment 2 2023-03-20 09:58:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11714
EWS
Comment 3 2023-03-20 11:31:24 PDT
Committed 261884@main (98754beb9912): <https://commits.webkit.org/261884@main> Reviewed commits have been landed. Closing PR #11714 and removing active labels.
EWS
Comment 4 2023-03-20 13:32:27 PDT
Committed 259548.450@safari-7615-branch (79f3c6391fc2): <https://commits.webkit.org/259548.450@safari-7615-branch> Reviewed commits have been landed. Closing PR #482 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.