Bug 254161 - [pre-push] Handle 'None' commits
Summary: [pre-push] Handle 'None' commits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-20 09:55 PDT by Jonathan Bedard
Modified: 2023-03-20 13:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-20 09:55:16 PDT 
`subprocess.run` does not handle 'None' arguments, so all of our '_for(commit)' functions in our pre-push hooks should return None if the commit argument provided is None.
Comment 1 Radar WebKit Bug Importer 2023-03-20 09:55:30 PDT 
<rdar://problem/106949161>
Comment 2 Jonathan Bedard 2023-03-20 09:58:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11714
Comment 3 EWS 2023-03-20 11:31:24 PDT 
Committed 261884@main (98754beb9912): <https://commits.webkit.org/261884@main>

Reviewed commits have been landed. Closing PR #11714 and removing active labels.
Comment 4 EWS 2023-03-20 13:32:27 PDT 
Committed 259548.450@safari-7615-branch (79f3c6391fc2): <https://commits.webkit.org/259548.450@safari-7615-branch>

Reviewed commits have been landed. Closing PR #482 and removing active labels.