Bug 254245 - REGRESSION(261912@main): [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html is a constant text failure
Summary: REGRESSION(261912@main): [ macOS ] media/modern-media-controls/macos-inline-m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-21 16:43 PDT by Robert Jenner
Modified: 2023-03-22 14:40 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2023-03-21 16:43:31 PDT
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html

is a constant text failure on macOS.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmacos-inline-media-controls%2Fmacos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html

TEXT DIFF:
@@ -8,7 +8,7 @@
 PASS mediaControls.topRightControlsBar.parent is mediaControls
 
 Mute button is disabled
-PASS mediaControls.muteButton.parent.parent is mediaControls.bottomControlsBar
+FAIL mediaControls.muteButton.parent.parent should be [object Object]. Was null.
 PASS mediaControls.topRightControlsBar.parent is null
 
 PASS successfullyParsed is true

DIFF URL:
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/261936@main%20(8307)/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled-pretty-diff.html
Comment 1 Radar WebKit Bug Importer 2023-03-21 16:46:44 PDT
<rdar://problem/107028528>
Comment 2 Robert Jenner 2023-03-21 16:58:40 PDT
I was able to reproduce the failure at Ventura Release ToT running the test as follows:


run-webkit-tests media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html

I also bisected to a regression point. The test fails at 261912@main, but not at 261911@main. 


Starting on Antoine who introduced https://commits.webkit.org/261912@main
Comment 3 EWS 2023-03-21 17:16:14 PDT
Test gardening commit 261941@main (f688023a9bc8): <https://commits.webkit.org/261941@main>

Reviewed commits have been landed. Closing PR #11785 and removing active labels.
Comment 4 Antoine Quint 2023-03-22 04:03:13 PDT
This test sets up media controls to be too narrow to display the mute button in the bottom controls bar and 261912@main enforced that. This test is no longer correct.
Comment 5 Antoine Quint 2023-03-22 07:40:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11808
Comment 6 EWS 2023-03-22 14:40:14 PDT
Committed 261991@main (934f8ed073f2): <https://commits.webkit.org/261991@main>

Reviewed commits have been landed. Closing PR #11808 and removing active labels.