Bug 254298 - Avoid unnecessary calls to updateGlobalPosition() in AnimationTimeline::animationTimingDidChange()
Summary: Avoid unnecessary calls to updateGlobalPosition() in AnimationTimeline::anima...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-22 16:50 PDT by Chris Dumez
Modified: 2023-03-22 19:31 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-22 16:50:29 PDT 
Update AnimationTimeline::animationTimingDidChange() to only call updateGlobalPosition() for new animations. For pre-existing animations, it is safe to assume they already have a global position.
Comment 1 Chris Dumez 2023-03-22 16:52:01 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11834
Comment 2 Chris Dumez 2023-03-22 19:31:52 PDT 
Patch is incorrect.