Bug 254313 - [JSC] Align RegExp V Flags Syntax errors with V8
Summary: [JSC] Align RegExp V Flags Syntax errors with V8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-22 21:25 PDT by Michael Saboff
Modified: 2023-03-23 08:27 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2023-03-22 21:25:06 PDT
Comparing the Syntax Errors from JSTests/stress/regexp-vflag-property-of-strings.js against what V8/Chrome produce some slightly different results.

For example, /[a--;;]/v produces the equivalent of JSC"s "invalid operation in class set" Syntax error instead of an "invalid class set character".

Most of the difference are of that type, or a few that are the inverse where V8 produces the equivalent of JSC's "invalid class set character" instead of "invalid operation in class set".
Comment 1 Radar WebKit Bug Importer 2023-03-22 21:29:48 PDT
<rdar://problem/107116409>
Comment 2 Michael Saboff 2023-03-22 21:44:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11850
Comment 3 EWS 2023-03-23 08:27:15 PDT
Committed 262017@main (825b9eb20878): <https://commits.webkit.org/262017@main>

Reviewed commits have been landed. Closing PR #11850 and removing active labels.