Bug 254322 - make all { No, Yes } and { Yes, No } enums use bool as underlying type
Summary: make all { No, Yes } and { Yes, No } enums use bool as underlying type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-23 04:23 PDT by Antoine Quint
Modified: 2023-03-23 08:51 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-03-23 04:23:30 PDT
We should make all Yes/No and No/Yes enums use bool as underlying type and reverse the values so that No==0 and Yes==1 as was done in bug 254309.
Comment 1 Antoine Quint 2023-03-23 04:30:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11857
Comment 2 EWS 2023-03-23 08:50:29 PDT
Committed 262018@main (44c9738463cc): <https://commits.webkit.org/262018@main>

Reviewed commits have been landed. Closing PR #11857 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-23 08:51:16 PDT
<rdar://problem/107137135>