Bug 254370 - The HTML fast parser may not parse HTML entities correctly
Summary: The HTML fast parser may not parse HTML entities correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-23 14:33 PDT by Chris Dumez
Modified: 2023-03-23 18:22 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-23 14:33:12 PDT 
The code was assuming consumeHTMLEntity() consumes all the input, which is not necessarily the case. This fixes cases where the reference is only part of the text.

This is a cherry-pick from Blink:
- https://chromium-review.googlesource.com/c/chromium/src/+/4305159
Comment 1 Chris Dumez 2023-03-23 14:35:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11888
Comment 2 EWS 2023-03-23 18:21:32 PDT 
Committed 262050@main (609c58ee5017): <https://commits.webkit.org/262050@main>

Reviewed commits have been landed. Closing PR #11888 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-23 18:22:15 PDT 
<rdar://problem/107164249>