Bug 254389 - Document Quirks.cpp with original bugs
Summary: Document Quirks.cpp with original bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-23 19:55 PDT by Karl Dubost
Modified: 2023-03-28 08:52 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2023-03-23 19:55:43 PDT 
Currently, it is difficult to find the source of a quirk. Blame doesn't always give the source of the issue (specifically after code rewriting).
It makes it hard for engineers who want to remove a quirk to go back in the history and find the origin and/or steps to reproduce the issue. 

The intent is to document with comments in the source code.
Comment 1 Radar WebKit Bug Importer 2023-03-23 19:56:16 PDT 
<rdar://problem/107167633>
Comment 2 Karl Dubost 2023-03-23 20:03:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11901
Comment 3 EWS 2023-03-28 08:52:02 PDT 
Committed 262216@main (afadc0ae8b64): <https://commits.webkit.org/262216@main>

Reviewed commits have been landed. Closing PR #11901 and removing active labels.