Bug 254396 - [RemoteInspector][Socket] non-blocking RunLoop::iterate is required
Summary: [RemoteInspector][Socket] non-blocking RunLoop::iterate is required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-23 22:20 PDT by haruhisa.shin
Modified: 2023-04-26 21:58 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description haruhisa.shin 2023-03-23 22:20:48 PDT 
RemoteInspector's thread for receiving socket data was processing messages via non-blocking RunLoop::iterate().
Since the commit https://github.com/WebKit/WebKit/commit/58887089c1f99919a7879162547ec7cf53548bbe replaced iterate() with cycle(), it is no longer possible to receive sockets.

We need a function that spins RunLoop without blocking the thread, so I propose that the RunLoop::iterate() be reinstated.
Comment 1 haruhisa.shin 2023-03-23 22:28:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11909
Comment 2 EWS 2023-03-27 18:10:11 PDT 
Committed 262188@main (677a38a7599f): <https://commits.webkit.org/262188@main>

Reviewed commits have been landed. Closing PR #11909 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-27 18:11:16 PDT 
<rdar://problem/107294258>
Comment 4 Fujii Hironori 2023-04-26 21:58:55 PDT 
Regressed: Bug 256028 – REGRESSION(262188@main) [Win] TestWTF.WTF_RunLoop.DispatchInRunLoopIterationDispatchesOnNextIteration1 is failing