Bug 254411 - @counter-style rules updated via CSSOM failed to update
Summary: @counter-style rules updated via CSSOM failed to update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-24 06:19 PDT by Vitor Roriz
Modified: 2023-03-28 03:00 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Roriz 2023-03-24 06:19:54 PDT 
If author updates @counter-style rule via CSSOM, we fail to update.
There are WPT tests that were already failing before due to missing @counter-styles that should be no longer failing now
that the feature got implemented. However, due to this behavior they keep failing:

Probably affected tests:

imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-additive-symbols-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-fallback-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-name-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-negative-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-pad-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-prefix-suffix-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-range-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-symbols-setter.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-system-setter-1.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-counter-styles/cssom/cssom-system-setter-2.html [ ImageOnlyFailure ]
Comment 1 Radar WebKit Bug Importer 2023-03-24 06:20:03 PDT 
<rdar://problem/107184142>
Comment 2 Vitor Roriz 2023-03-25 09:45:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11948
Comment 3 EWS 2023-03-28 03:00:03 PDT 
Committed 262203@main (3fa329db6bad): <https://commits.webkit.org/262203@main>

Reviewed commits have been landed. Closing PR #11948 and removing active labels.