Bug 254441 - JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a buffer when it is a substring
Summary: JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 254474
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-24 12:35 PDT by Chris Dumez
Modified: 2023-03-25 19:37 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-24 12:35:57 PDT 
JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a buffer when it is a substring, we can construct the AtomString straight from the StringView::substring() output.
Comment 1 Chris Dumez 2023-03-24 12:37:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11946
Comment 2 EWS 2023-03-24 15:39:18 PDT 
Committed 262103@main (3bc3bb7a66f1): <https://commits.webkit.org/262103@main>

Reviewed commits have been landed. Closing PR #11946 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-24 15:40:22 PDT 
<rdar://problem/107205966>