Bug 254443 - AX: Only FRED VP visible on the Text To Speech Sound Check page
Summary: AX: Only FRED VP visible on the Text To Speech Sound Check page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-24 12:52 PDT by chris fleizach
Modified: 2023-03-25 15:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2023-03-24 13:38 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2023-03-24 15:19 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2023-03-24 15:32 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2023-03-24 16:52 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2023-03-24 12:52:39 PDT
Only Fred is available sometimes
Comment 1 Radar WebKit Bug Importer 2023-03-24 12:52:49 PDT
<rdar://problem/107199586>
Comment 2 chris fleizach 2023-03-24 13:38:26 PDT
Created attachment 465575 [details]
Patch
Comment 3 chris fleizach 2023-03-24 15:19:21 PDT
Created attachment 465576 [details]
Patch
Comment 4 chris fleizach 2023-03-24 15:32:01 PDT
Created attachment 465577 [details]
Patch
Comment 5 Tyler Wilcock 2023-03-24 15:58:28 PDT
Comment on attachment 465577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465577&action=review

> COMMIT_MESSAGE:2
> +https://bugs.webkit.org/show_bug.cgi?id=254443

I think you need a Radar link below your Bugzilla URL. If you re-run `git-webkit setup` this should start appearing in your commit message template.

> LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:9
> +    description("This tests that we can get Samantha.");

Can probably move everything inside this script tag back one indentation level.

> LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:12
> +    var speech = window.speechSynthesis;
> +    var list = speech.getVoices();

Seems like we only use this `var speech` in one place. Might make the test a bit more clean to directly use window.speechSynthesis to `getVoices()`.

> LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:22
> +

This newline seems unnecessary.
Comment 6 chris fleizach 2023-03-24 16:52:54 PDT
Created attachment 465578 [details]
Patch
Comment 7 EWS 2023-03-25 15:20:49 PDT
Committed 262117@main (f20573ec09c6): <https://commits.webkit.org/262117@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465578 [details].