Bug 254474 - Regression(262103@main) JSRopeString::resolveRopeToAtomString() no longer reports extra memory
Summary: Regression(262103@main) JSRopeString::resolveRopeToAtomString() no longer rep...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 254441
  Show dependency tree / graph
 
Reported: 2023-03-25 19:34 PDT by Chris Dumez
Modified: 2023-03-27 10:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-25 19:34:59 PDT 
JSRopeString::resolveRopeToAtomString() no longer reports extra memory since 262103@main. Because we're holding the resolved rope as an AtomString, `valueInternal().impl()->hasOneRef()` could never be true.
Comment 1 Chris Dumez 2023-03-25 19:36:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11977
Comment 2 EWS 2023-03-27 10:31:55 PDT 
Committed 262158@main (0a0fdf90f82f): <https://commits.webkit.org/262158@main>

Reviewed commits have been landed. Closing PR #11977 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-27 10:32:24 PDT 
<rdar://problem/107273738>