Bug 254524 - Refactor StyleRuleCounterStyle for eliminating StyleProperties
Summary: Refactor StyleRuleCounterStyle for eliminating StyleProperties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-27 08:17 PDT by Vitor Roriz
Modified: 2023-03-31 04:17 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Roriz 2023-03-27 08:17:59 PDT 
StyleRuleCounterStyle currently stores `StyleProperties` besides `CSSCounterStyleDescriptors`.
This is used for facilitating serialization and read/write for the CSSOM api. We can get rid of the `StyleProperties` member and
use only `CSSCounterStyleDescriptors` after we write a serializer for each descriptor and adapt the setter function for setting only the `CSSCounterStyleDescriptors`
Comment 1 Radar WebKit Bug Importer 2023-03-27 08:18:10 PDT 
<rdar://problem/107267784>
Comment 2 Vitor Roriz 2023-03-30 03:58:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12168
Comment 3 EWS 2023-03-31 04:17:07 PDT 
Committed 262396@main (b96c4a014f18): <https://commits.webkit.org/262396@main>

Reviewed commits have been landed. Closing PR #12168 and removing active labels.