Bug 254627 - [git-webkit] Prevent publication of commits for redacted PRs
Summary: [git-webkit] Prevent publication of commits for redacted PRs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-28 16:36 PDT by Jonathan Bedard
Modified: 2023-04-18 15:36 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-28 16:36:36 PDT
By design, git-webkit makes it very hard to opt-in to publishing a fix for a redacted PR. The recent addition of a pre-push hook makes this less crucial, because regardless of how a user answers prompts by `git-webkit`, any push containing a redacted issue will prompt the user before contacting the server. `git-webkit` should respect a user when they explicitly request to make a fix for a redacted issue public.
Comment 1 Radar WebKit Bug Importer 2023-03-28 17:18:00 PDT
<rdar://problem/107343169>
Comment 2 Jonathan Bedard 2023-03-29 07:01:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12110
Comment 3 Jonathan Bedard 2023-04-05 11:39:52 PDT
After talking with Geoff and landing https://commits.webkit.org/262617@main, we're basically going to do the exact opposite of this: we're going to forbid publication of commits for redacted PRs in all circumstances. I'm going to re-purpose this bug because anyone following it already will care about us doing the inverse.
Comment 4 EWS 2023-04-18 15:36:44 PDT
Committed 263101@main (9384f300d865): <https://commits.webkit.org/263101@main>

Reviewed commits have been landed. Closing PR #12110 and removing active labels.