Bug 254646 - RenderBox::computeInlineDirectionMargins() is causing system malloc heap allocations
Summary: RenderBox::computeInlineDirectionMargins() is causing system malloc heap allo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-28 22:04 PDT by Chris Dumez
Modified: 2023-03-29 08:25 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-28 22:04:56 PDT 
RenderBox::computeInlineDirectionMargins() is causing system malloc heap allocations:

Sample Count, Samples %, Normalized CPU %, Symbol
21, 0.0%, 0.0%, tiny_malloc_should_clear (in libsystem_malloc.dylib)
20, 0.0%, 0.0%,     szone_malloc_should_clear (in libsystem_malloc.dylib)
8, 0.0%, 0.0%,         operator new(unsigned long) (in libc++abi.dylib)
5, 0.0%, 0.0%,             WebCore::RenderBox::computeInlineDirectionMargins(WebCore::RenderBlock const&, WebCore::LayoutUnit, std::__1::optional<WebCore::LayoutUnit>, WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)
3, 0.0%, 0.0%,             WebCore::RenderBox::fillAvailableMeasure(WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)


Sample Count, Samples %, Normalized CPU %, Symbol
15, 0.0%, 0.0%, _malloc_zone_malloc (in libsystem_malloc.dylib)
5, 0.0%, 0.0%,     WebCore::RenderBox::fillAvailableMeasure(WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)
5, 0.0%, 0.0%,     WebCore::RenderBox::computeInlineDirectionMargins(WebCore::RenderBlock const&, WebCore::LayoutUnit, std::__1::optional<WebCore::LayoutUnit>, WebCore::LayoutUnit, WebCore::LayoutUnit&, WebCore::LayoutUnit&) const (in WebCore)


Sample Count, Samples %, Normalized CPU %, Symbol
13, 0.0%, 0.0%, free (in libsystem_malloc.dylib)
6, 0.0%, 0.0%,     WebCore::RenderBox::computeLogicalWidthInFragment(WebCore::RenderBox::LogicalExtentComputedValues&, WebCore::RenderFragmentContainer*) const (in WebCore)
3, 0.0%, 0.0%,     __CFRunLoopDoTimers (in CoreFoundation)
3, 0.0%, 0.0%,     WebCore::RenderBox::computeLogicalWidthInFragmentUsing(WebCore::SizeType, WebCore::Length, WebCore::LayoutUnit, WebCore::RenderBlock const&, WebCore::RenderFragmentContainer*) const (in WebCore)
1, 0.0%, 0.0%,     JSC::PreciseAllocation::sweep() (in JavaScriptCore)
Comment 1 Chris Dumez 2023-03-28 22:07:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12096
Comment 2 EWS 2023-03-29 08:24:46 PDT 
Committed 262274@main (ea7b758f5d2e): <https://commits.webkit.org/262274@main>

Reviewed commits have been landed. Closing PR #12096 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-29 08:25:15 PDT 
<rdar://problem/107368542>