WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
254663
CacheStorageManager creates 'salt' file in cwd when there is no path
https://bugs.webkit.org/show_bug.cgi?id=254663
Summary
CacheStorageManager creates 'salt' file in cwd when there is no path
Max Schmitt
Reported
2023-03-29 08:22:38 PDT
As per:
https://github.com/WebKit/WebKit/blob/1490a5c2a806d767de0b4e2dd113a35053467eea/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp#L571
m_path from here:
https://github.com/WebKit/WebKit/blob/1490a5c2a806d767de0b4e2dd113a35053467eea/Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp#L233
can be an empty string. This regressed in
https://github.com/WebKit/WebKit/commit/5d9c260954a94cf6ce71bf69ab4b23c92b8e3e02
that a random file in the CWD with the name 'salt' gets created because the
https://github.com/WebKit/WebKit/blob/1490a5c2a806d767de0b4e2dd113a35053467eea/Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp#L228
does not check if m_path is an empty string.
Attachments
Add attachment
proposed patch, testcase, etc.
Max Schmitt
Comment 1
2023-03-29 08:55:29 PDT
Pull Request:
https://github.com/WebKit/WebKit/pull/12116
EWS
Comment 2
2023-03-29 14:44:23 PDT
Committed
262291@main
(8dfdc492a47b): <
https://commits.webkit.org/262291@main
> Reviewed commits have been landed. Closing PR #12116 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-03-29 14:45:19 PDT
<
rdar://problem/107387306
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug