Bug 254675 - [Margin-trim] Remove a virtual function call on this rare property while computing margins
Summary: [Margin-trim] Remove a virtual function call on this rare property while comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-29 11:12 PDT by zalan
Modified: 2023-03-31 06:20 PDT (History)
14 users (show)

See Also:

Attachments
Patch (10.12 KB, patch)
2023-03-29 11:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.12 KB, patch)
2023-03-29 11:43 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.73 KB, patch)
2023-03-29 11:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.73 KB, patch)
2023-03-29 12:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (9.63 KB, patch)
2023-03-30 19:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-03-29 11:12:06 PDT 
ssia
Comment 1 zalan 2023-03-29 11:17:23 PDT 
Created attachment 465665 [details]
Patch
Comment 2 Chris Dumez 2023-03-29 11:36:32 PDT 
Comment on attachment 465665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465665&action=review

> Source/WebCore/rendering/RenderBox.cpp:3796
> +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const

Would be nice to make this inline.
Comment 3 zalan 2023-03-29 11:43:08 PDT 
Created attachment 465666 [details]
Patch
Comment 4 zalan 2023-03-29 11:45:01 PDT 
Created attachment 465667 [details]
Patch
Comment 5 zalan 2023-03-29 11:45:47 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 465665 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465665&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:3796
> > +bool RenderBox::shouldTrimChildMargin(MarginTrimType marginTrimType, const RenderBox& child) const
> 
> Would be nice to make this inline.
good point!
Comment 6 Chris Dumez 2023-03-29 12:08:21 PDT 
Comment on attachment 465667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465667&action=review

r=me

> Source/WebCore/rendering/RenderBox.h:313
> +    bool shouldTrimChildMargin(MarginTrimType, const RenderBox&) const;

This can likely be protected.
Comment 7 zalan 2023-03-29 12:56:28 PDT 
Created attachment 465668 [details]
Patch
Comment 8 zalan 2023-03-30 19:56:30 PDT 
Created attachment 465695 [details]
[fast-cq]Patch
Comment 9 EWS 2023-03-31 06:19:35 PDT 
Committed 262399@main (dd0e3196e184): <https://commits.webkit.org/262399@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465695 [details].
Comment 10 Radar WebKit Bug Importer 2023-03-31 06:20:17 PDT 
<rdar://problem/107469302>