Bug 254677 - [git-webkit] Look for hooks in the GIT_DIR, not the worktree
Summary: [git-webkit] Look for hooks in the GIT_DIR, not the worktree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-29 12:22 PDT by Elliott Williams
Modified: 2023-03-30 14:14 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-03-29 12:22:21 PDT 
Currently, git-webkit assumes hooks are in a ".git/hooks" directory relative to the top-level worktree directory. This is not the case for repos with multiple worktrees or other exotic setups.
Comment 1 Elliott Williams 2023-03-29 12:24:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12126
Comment 2 EWS 2023-03-29 14:07:21 PDT 
Committed 262288@main (f05f3c942884): <https://commits.webkit.org/262288@main>

Reviewed commits have been landed. Closing PR #12126 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-29 14:08:18 PDT 
<rdar://problem/107385426>
Comment 4 EWS 2023-03-30 14:14:45 PDT 
Committed 259548.523@safari-7615-branch (db241bbd3a36): <https://commits.webkit.org/259548.523@safari-7615-branch>

Reviewed commits have been landed. Closing PR #509 and removing active labels.