Bug 254682 - [css-conditional] Some pseudo-elements should be known in @supports selector()
Summary: [css-conditional] Some pseudo-elements should be known in @supports selector()
Status: RESOLVED DUPLICATE of bug 241847
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://wpt.fyi/results/css/css-condi...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-29 12:52 PDT by Tim Nguyen (:ntim)
Modified: 2023-03-29 19:42 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-03-29 12:52:12 PDT 
See LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-047.html

We fail to parse `@supports selector(input::placeholder)`

http://wpt.live/css/css-conditional/at-supports-047.html
Comment 1 Tim Nguyen (:ntim) 2023-03-29 13:20:23 PDT 
So we reject ::placeholder/::file-selector-button (which do fall under CSSSelector::PseudoElementWebKitCustom) in:

https://searchfox.org/wubkat/rev/4c1d077ec985eb840a20e5ffb65eb2b73fb89d31/Source/WebCore/css/parser/CSSSelectorParser.cpp#182

We probably shouldn't do this. Joonghun, do you have some context around this?

Do we want to reject PseudoElementWebKitCustomLegacyPrefixed instead? or simply stop rejecting anything that's parsable?
Comment 2 Tim Nguyen (:ntim) 2023-03-29 19:31:46 PDT 

*** This bug has been marked as a duplicate of bug 241847 ***
Comment 3 Joonghun Park 2023-03-29 19:42:00 PDT 
(In reply to Tim Nguyen (:ntim) from comment #1)
> So we reject ::placeholder/::file-selector-button (which do fall under
> CSSSelector::PseudoElementWebKitCustom) in:
> 
> https://searchfox.org/wubkat/rev/4c1d077ec985eb840a20e5ffb65eb2b73fb89d31/
> Source/WebCore/css/parser/CSSSelectorParser.cpp#182
> 
> We probably shouldn't do this. Joonghun, do you have some context around
> this?
> 
> Do we want to reject PseudoElementWebKitCustomLegacyPrefixed instead? or
> simply stop rejecting anything that's parsable?

It seems that I need to look into the related codes in detail to recall.
I will check on it.