WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
254702
Make SMIL interval position calculations more resilient
https://bugs.webkit.org/show_bug.cgi?id=254702
Summary
Make SMIL interval position calculations more resilient
Ahmad Saleem
Reported
2023-03-29 16:22:55 PDT
Hi Team, While going through Blink's commits, I came across another potential merge. Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/c9db58439d9c5218b26640fa65780d6dd505734c
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/svg/animation/SVGSMILElement.cpp#1033
________ double lastActiveDuration = elapsed >= m_intervalEnd ? m_intervalEnd.value() - m_intervalBegin.value() : repeatingDuration.value(); double percent = lastActiveDuration / simpleDuration.value(); __________ It compiles on local build on ToT based on above. Just wanted to raise so we can fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-03-31 11:03:20 PDT
Committed
262425@main
(41db051039b0): <
https://commits.webkit.org/262425@main
> Reviewed commits have been landed. Closing PR #12210 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-03-31 11:04:28 PDT
<
rdar://problem/107479595
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug