Bug 254717 - Consider moving wtf/fast_float to a ThirdParty directory
Summary: Consider moving wtf/fast_float to a ThirdParty directory
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-29 19:28 PDT by Elliott Williams
Modified: 2023-04-05 19:29 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-03-29 19:28:14 PDT
Right now, it's not clear that we bundle fast_float <https://github.com/fastfloat/fast_float> inside of WTF. There is precedent for a ThirdParty directory nested inside a project directory, e.g. Source/WebCore/PAL/ThirdParty/libavif/. We should do the same thing for fast_float and move it to Source/WTF/ThirdParty/fast_float/.

This ought to be useful for distributions tracking which copyrighted works they ship, and it makes it easier to understand why code is that directory does not always conform to coding style, etc.
Comment 1 Michael Catanzaro 2023-04-03 06:05:59 PDT
This Apache-licensed code changes the "effective license" of WebKit. I thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications cannot depend on WebKit (although, fortunately, I doubt any such applications exist).

We need to get the license right. This means either removing this code or else updating https://webkit.org/licensing-webkit/
Comment 2 Yusuke Suzuki 2023-04-03 09:18:06 PDT
(In reply to Michael Catanzaro from comment #1)
> This Apache-licensed code changes the "effective license" of WebKit. I
> thought WebKit's license was (BSD and LGPLv2+), but surprise! it's actually
> (BSD and LPGLv2+ and Apache). Notably, it means GPLv2-only applications
> cannot depend on WebKit (although, fortunately, I doubt any such
> applications exist).
> 
> We need to get the license right. This means either removing this code or
> else updating https://webkit.org/licensing-webkit/

libwebrtc is Apache license for example.
Comment 3 Yusuke Suzuki 2023-04-03 09:20:30 PDT
Also, ANGLE, pdfjs
Comment 4 Michael Catanzaro 2023-04-03 10:09:09 PDT
OK, we need to update https://webkit.org/licensing-webkit/
Comment 5 Radar WebKit Bug Importer 2023-04-05 19:29:18 PDT
<rdar://problem/107690836>