Bug 254873 - Prevent mixing of generate and generateThreadSafe at compile time
Summary: Prevent mixing of generate and generateThreadSafe at compile time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-01 20:15 PDT by Matt Woodrow
Modified: 2023-04-08 16:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-04-01 20:15:41 PDT 
generate and generateThreadSafe use separate counters, so mixing usage will results in collisions.

We can make this a template parameter instead, and prevent mixing at compile time.
Comment 1 Matt Woodrow 2023-04-02 00:21:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12288
Comment 2 EWS 2023-04-07 22:05:20 PDT 
Committed 262749@main (1641f98f8e48): <https://commits.webkit.org/262749@main>

Reviewed commits have been landed. Closing PR #12288 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-07 22:06:18 PDT 
<rdar://problem/107781219>