Bug 254925 - [GPU Process] Refactor ShareableBitmapConfiguration
Summary: [GPU Process] Refactor ShareableBitmapConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 254794
  Show dependency tree / graph
 
Reported: 2023-04-03 11:09 PDT by Said Abou-Hallawa
Modified: 2023-04-04 12:44 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-04-03 11:09:49 PDT 
ShareableBitmapConfiguration needs to hold the size of the ShareableBitmap so it can self calculate the sizeInBytes. Also it should hold and IPC the bitmap properties instead of calculating them every time they are needed. The caller should create ShareableBitmap only if sizeInBytes does not have overflow. So ShareableBitmapConfiguration does not have to return the bitmap properties in CheckedUint32 but just unsigned.
Comment 1 Radar WebKit Bug Importer 2023-04-03 11:10:33 PDT 
<rdar://problem/107567337>
Comment 2 Said Abou-Hallawa 2023-04-03 11:10:51 PDT 
This work is towards bug 254794.
Comment 3 Said Abou-Hallawa 2023-04-03 11:14:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12325
Comment 4 EWS 2023-04-03 17:31:20 PDT 
Committed 262547@main (ecd29c94a787): <https://commits.webkit.org/262547@main>

Reviewed commits have been landed. Closing PR #12325 and removing active labels.