Bug 255007 - [git-webkit] Cache filed bug
Summary: [git-webkit] Cache filed bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-04 14:01 PDT by Jonathan Bedard
Modified: 2023-05-04 12:36 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-04-04 14:01:41 PDT
git-webkit pr passes the filed bug to `git commit` via environment variables. That technique often works well, however, if a user files a bug via `git-webkit branch` or is forced to resolve a conflict during `git-webkit cherry-pick`, we will lose the data we pass via environment variable to `git`. We should save this information to disk as well, and pick up the environment on disk in our commit message generator so that we can pass commit title and bug details in this circumstance.
Comment 1 Radar WebKit Bug Importer 2023-04-04 14:01:59 PDT
<rdar://problem/107629444>
Comment 2 Jonathan Bedard 2023-04-05 11:04:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12414
Comment 3 EWS 2023-05-03 11:58:13 PDT
Committed 263641@main (2425de1c879b): <https://commits.webkit.org/263641@main>

Reviewed commits have been landed. Closing PR #12414 and removing active labels.
Comment 4 Jonathan Bedard 2023-05-04 11:43:01 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/13452
Comment 5 EWS 2023-05-04 11:55:54 PDT
Committed 263687@main (c8b247965127): <https://commits.webkit.org/263687@main>

Reviewed commits have been landed. Closing PR #13452 and removing active labels.
Comment 6 EWS 2023-05-04 12:36:15 PDT
Committed 259548.736@safari-7615-branch (3597549574e5): <https://commits.webkit.org/259548.736@safari-7615-branch>

Reviewed commits have been landed. Closing PR #577 and removing active labels.