Bug 255022 - [css-grid] grid-template-rows: masonry has an effect, even when the feature is turned off
Summary: [css-grid] grid-template-rows: masonry has an effect, even when the feature i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 16
Hardware: All All
: P2 Normal
Assignee: Brandon
URL: https://codesandbox.io/s/festive-moon...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-05 01:28 PDT by William Killerud
Modified: 2023-05-30 19:40 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Killerud 2023-04-05 01:28:02 PDT
Affects Safari 16.4 and Technical Preview 166.

With the experimental feature CSS Masonry Layout turned OFF, when grid-template-rows: masonry is present, the grid is laid out with a masonry effect. `@supports (grid-template-rows: masonry)` matches as well.

The masonry layout has some issues that break certain layouts, so this seemingly accidental introduction of the feature is a bit unfortunate.

Demo: https://codesandbox.io/s/festive-moon-n16ycr?file=/src/styles.css:40-79

In Safari 16.4 with the CSS Masonry Layout experimental feature turned OFF, I would expect not to see the text "This browsesr supports masonry".

Firefox behaves correctly, only showing the text when the feature flag is turned on.
Comment 1 Radar WebKit Bug Importer 2023-04-05 10:30:15 PDT
<rdar://problem/107666160>
Comment 2 Brandon 2023-04-05 15:37:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12433
Comment 3 Brandon 2023-04-05 15:37:53 PDT
Just posted a PR to fix this. Thanks for reporting it.
Comment 4 EWS 2023-04-06 11:05:42 PDT
Committed 262670@main (ef3245fe7ca0): <https://commits.webkit.org/262670@main>

Reviewed commits have been landed. Closing PR #12433 and removing active labels.
Comment 5 zalan 2023-05-30 19:40:11 PDT
*** Bug 257509 has been marked as a duplicate of this bug. ***