Bug 255035 - [ews] A PR that failed to fix a pre-existing test failure was marked as green even though the test was still failing
Summary: [ews] A PR that failed to fix a pre-existing test failure was marked as green...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 258005 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-04-05 09:20 PDT by Ryan Haddad
Modified: 2023-06-13 06:43 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2023-04-05 09:20:43 PDT 
Here is an interesting case with our EWS + results DB integration, but I’m not sure how we’d mitigate it: 
https://github.com/WebKit/WebKit/pull/11769 was supposed to fix TestWebKitAPI.WebKit.MediaBufferingPolicy, and since EWS was ignoring the failure based on post-commit results, it ignored the fact that the test continued to fail with the PR and marked the run as ✅ https://ews-build.webkit.org/#/builders/18/builds/1253
Comment 1 Radar WebKit Bug Importer 2023-04-05 09:20:54 PDT 
<rdar://problem/107662421>
Comment 2 Ryan Haddad 2023-06-13 06:43:07 PDT 
*** Bug 258005 has been marked as a duplicate of this bug. ***