Bug 255066 - [webkit-bot] Reverting a revert should re-land with the original commit message.
Summary: [webkit-bot] Reverting a revert should re-land with the original commit message.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-05 16:53 PDT by Ryan Reno
Modified: 2023-04-06 22:39 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2023-04-05 16:53:56 PDT
It would be great to use webkit-bot to revert a revert and have it restore the original commit message with an annotation that this is a re-land.

As it is now if I ask webkit-bot to revert a revert it treats it like any other revert (giving it a REGRESSION title and the rest of it.) For example I reverted 262331@main (https://commits.webkit.org/262331@main) in 262370@main (https://commits.webkit.org/262370@main) and then re-landed in 262429@main (https://commits.webkit.org/262429@main) which only refers to the original commit because I asked the bot to say this is a re-land.

I could manually do the work to re-land in a manual PR but webkit-bot is very convenient for these mechanical tasks and so it would be nice to have it restore the commit message in these situations.

A secondary but related goal would be to commit with the original author's information as well so we don't have commits to the repo from "Commit-Queue" in these situations.
Comment 1 Radar WebKit Bug Importer 2023-04-05 16:54:07 PDT
<rdar://problem/107685551>
Comment 2 Ryan Reno 2023-04-05 16:55:08 PDT
Off-topic but I had no idea bugzilla created links from commit IDs automatically - nice!