Bug 255118 - Fix incorrect uses of containingBlock in ComputedStyleExtractor rendererCanHaveTrimmedMargin
Summary: Fix incorrect uses of containingBlock in ComputedStyleExtractor rendererCanHa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-06 14:12 PDT by Sammy Gill
Modified: 2023-05-02 20:11 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-04-06 14:12:09 PDT 
This function incorrectly uses the term "containingBlock" without first determining the formatting context it is in. It should first determine the formatting context and then use either "formattingContextRoot" or the correct name of the formatting context root (e.g. flexbox/grid)
Comment 1 Radar WebKit Bug Importer 2023-04-06 14:12:42 PDT 
<rdar://problem/107726833>
Comment 2 Sammy Gill 2023-04-28 12:30:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13284
Comment 3 EWS 2023-05-02 20:11:38 PDT 
Committed 263616@main (69af735e2796): <https://commits.webkit.org/263616@main>

Reviewed commits have been landed. Closing PR #13284 and removing active labels.