Bug 255121 - [prepare-commit-msg] Fix 'git commit --reedit-message'
Summary: [prepare-commit-msg] Fix 'git commit --reedit-message'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-06 15:02 PDT by Jonathan Bedard
Modified: 2023-04-06 15:12 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-04-06 15:02:41 PDT 
While 'git commit --amend' works, that's only because we hard-code HEAD in our prepare-commit-msg hook. We should instead use the argument 'git commit' is providing us.
Comment 1 Radar WebKit Bug Importer 2023-04-06 15:02:56 PDT 
<rdar://problem/107729416>
Comment 2 Jonathan Bedard 2023-04-06 15:06:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12480
Comment 3 EWS 2023-04-06 15:12:21 PDT 
Committed 262688@main (ba739f2564d7): <https://commits.webkit.org/262688@main>

Reviewed commits have been landed. Closing PR #12480 and removing active labels.