Bug 255127 - [WGSL] Distinguish between abstract and concrete float literals
Summary: [WGSL] Distinguish between abstract and concrete float literals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-06 16:28 PDT by Dan Glastonbury
Modified: 2023-04-07 15:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2023-04-06 16:28:04 PDT 
Lexing did not correctly distinguish between an "abstract" and "concrete" floating point
literals. Eg. 124.0 vs 124.0f. This patch implements the distinction via tokens
AbstractFloatLiteral and FloatLiteral.

Also, not all cases of concrete literals specified with suffix 'f' were lexed
correctly. Added these cases and tests.
Comment 1 Radar WebKit Bug Importer 2023-04-06 16:28:16 PDT 
<rdar://problem/107732951>
Comment 2 Dan Glastonbury 2023-04-06 16:32:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12485
Comment 3 EWS 2023-04-07 15:45:17 PDT 
Committed 262732@main (8df3beb4ce36): <https://commits.webkit.org/262732@main>

Reviewed commits have been landed. Closing PR #12485 and removing active labels.