RESOLVED FIXED255260
REBASELINE REGRESSION(262768@main): [ iOS ]4X fast/block/lineboxcontain (layout-tests) are constant text failures 
https://bugs.webkit.org/show_bug.cgi?id=255260
Summary REBASELINE REGRESSION(262768@main): [ iOS ]4X fast/block/lineboxcontain (layo...
Robert Jenner
Reported 2023-04-10 16:40:18 PDT
fast/block/lineboxcontain/font-replaced.html fast/block/lineboxcontain/inline-box-replaced.html fast/block/lineboxcontain/inline-box-vertical.html fast/block/lineboxcontain/inline-box.html are constant text failures on iOS. HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fblock%2Flineboxcontain%2Finline-box.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-vertical.html&test=fast%2Fblock%2Flineboxcontain%2Finline-box-replaced.html&test=fast%2Fblock%2Flineboxcontain%2Ffont-replaced.html URL to DIFFS: https://build.webkit.org/results/Apple-iOS-16-Simulator-Debug-WK2-Tests/262783@main%20(903)/results.html All tests appear to be off by just 1 pixel.
Attachments
Add attachment proposed patch, testcase, etc.
Robert Jenner
Comment 1 2023-04-10 16:52:31 PDT
I was able to reproduce these failures on iOS 16 Production ToT running the tests as follows: run-webkit-tests --iOS-simulator <test_goes_here> I was also able to bisect to a specific regression point. The failures occurred at 262768@main, but not at 262767@main. So it does appear that changes at https://commits.webkit.org/262768@main caused these tests to fail. However, these tests also appear to just need some re-baselines as they are only off by 1 pixel each.
Radar WebKit Bug Importer
Comment 2 2023-04-10 16:52:55 PDT
<rdar://problem/107857807>
alan
Comment 3 2023-04-10 16:57:50 PDT
> So it does appear that changes at https://commits.webkit.org/262768@main > caused these tests to fail. However, these tests also appear to just need > some re-baselines as they are only off by 1 pixel each. Correct. Sorry about that. :|
EWS
Comment 4 2023-04-10 17:08:58 PDT
Test gardening commit 262794@main (2b7c4bdd1878): <https://commits.webkit.org/262794@main> Reviewed commits have been landed. Closing PR #12595 and removing active labels.
Robert Jenner
Comment 5 2023-04-10 17:09:32 PDT
(In reply to zalan from comment #3) > > So it does appear that changes at https://commits.webkit.org/262768@main > > caused these tests to fail. However, these tests also appear to just need > > some re-baselines as they are only off by 1 pixel each. > Correct. Sorry about that. :| No worries! I got it taken care of at https://commits.webkit.org/262794@main
alan
Comment 6 2023-04-10 17:17:15 PDT
(In reply to Robert Jenner from comment #5) > (In reply to zalan from comment #3) > > > So it does appear that changes at https://commits.webkit.org/262768@main > > > caused these tests to fail. However, these tests also appear to just need > > > some re-baselines as they are only off by 1 pixel each. > > Correct. Sorry about that. :| > > No worries! I got it taken care of at https://commits.webkit.org/262794@main Thank you!
Note You need to log in before you can comment on or make changes to this bug.