Bug 255369 - [iOS] Make eager soft-linking of Data Detection frameworks non-fatal
Summary: [iOS] Make eager soft-linking of Data Detection frameworks non-fatal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 241267
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-12 15:15 PDT by Brent Fulgham
Modified: 2023-04-19 16:29 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-04-12 15:15:27 PDT
Crash telemetry indicates that soft-linking of the Data Detection frameworks fails on some devices, perhaps when the screen is locked. Since this eager-linking was meant to improve performance, and we can re-soft-link later if the initial attempt fails, we should try and fail gracefully if the directory is not accessible.

This should not introduce any change in behavior, as cases that used to work should continue. It should simply reduce the changes of a failure terminating a web process prematurely.
Comment 1 Brent Fulgham 2023-04-12 15:16:17 PDT
<rdar://107752677>
Comment 2 Brent Fulgham 2023-04-12 15:33:04 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12674
Comment 3 Brent Fulgham 2023-04-18 17:00:04 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12894
Comment 4 EWS 2023-04-19 16:29:31 PDT
Committed 263154@main (ee46c752943b): <https://commits.webkit.org/263154@main>

Reviewed commits have been landed. Closing PR #12894 and removing active labels.