Bug 255388 - Screen orientation type should be counter-clockwise
Summary: Screen orientation type should be counter-clockwise
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari 16
Hardware: iPhone / iPad iOS 16
: P2 Normal
Assignee: Marcos Caceres
URL: https://github.com/w3c/screen-orienta...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-12 21:52 PDT by Marcos Caceres
Modified: 2023-04-13 18:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Caceres 2023-04-12 21:52:17 PDT 
A followup from this bug:
https://bugs.webkit.org/show_bug.cgi?id=254863

Resulted in a spec change to match Firefox and Chrome with respect to what each orientation type is (they do it counter clockwise for some reason):
https://github.com/w3c/screen-orientation/issues/247

So, for when natural orientation is portrait, iOS reports landscape-primary as landscape-secondary and vice versa.

It's probably "incorrect" also for when the natural orientation is landscape, but will confirm.
Comment 1 Radar WebKit Bug Importer 2023-04-12 22:13:06 PDT 
<rdar://problem/107976966>
Comment 2 Marcos Caceres 2023-04-12 22:16:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12687
Comment 3 Marcos Caceres 2023-04-12 22:22:49 PDT 
Spec change is actually at https://github.com/w3c/screen-orientation/pull/248
Comment 4 EWS 2023-04-13 18:12:50 PDT 
Committed 262940@main (9a0e8865a0f5): <https://commits.webkit.org/262940@main>

Reviewed commits have been landed. Closing PR #12687 and removing active labels.