Bug 255440 - Remove finishCreation()s that only call its superclass' finishCreation().
Summary: Remove finishCreation()s that only call its superclass' finishCreation().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-13 23:04 PDT by Mark Lam
Modified: 2023-04-14 12:23 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-04-13 23:04:25 PDT 
Introduce a DECLARE_DEFAULT_FINISH_CREATION macro to define finishCreation() when ASSERT_ENABLED, and to use Base::finishCreation when not ASSERT_ENABLED.  Change code in JSC to use DECLARE_DEFAULT_FINISH_CREATION when finishCreation() is trivial i.e. effectively just calls the superclass version.

Also change CodeGeneratorJS.pm to do that same.
Comment 1 Radar WebKit Bug Importer 2023-04-13 23:04:48 PDT 
<rdar://problem/108034039>
Comment 2 Mark Lam 2023-04-13 23:15:04 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12732
Comment 3 EWS 2023-04-14 12:23:54 PDT 
Committed 262983@main (7dbeef1bd19f): <https://commits.webkit.org/262983@main>

Reviewed commits have been landed. Closing PR #12732 and removing active labels.