Bug 255528 - [git-webkit] Do not include indented trailers
Summary: [git-webkit] Do not include indented trailers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-17 09:29 PDT by Jonathan Bedard
Modified: 2023-04-17 11:12 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-04-17 09:29:04 PDT 
Trailers from a cherry-picked commit should not be included as trailers to current commit. In general, this is a problem because WebKit permits trailers to include whitespace where as `git` does not. WebKit should not respect trailers which _begin_ with whitespace, though.
Comment 1 Radar WebKit Bug Importer 2023-04-17 09:29:20 PDT 
<rdar://problem/108143386>
Comment 2 Jonathan Bedard 2023-04-17 09:42:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12808
Comment 3 EWS 2023-04-17 11:12:38 PDT 
Committed 263027@main (3338c3aac8ff): <https://commits.webkit.org/263027@main>

Reviewed commits have been landed. Closing PR #12808 and removing active labels.