Bug 255559 - [ews-build.webkit.org] Refuse to land security changes via Commit-Queue
Summary: [ews-build.webkit.org] Refuse to land security changes via Commit-Queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-17 16:47 PDT by Jonathan Bedard
Modified: 2023-04-18 13:51 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-04-17 16:47:40 PDT 
Security changes should be landed via GitHub, so that the WebKit project can decide which branches to land them on. Landing security changes on `main` is almost always incorrect, so Commit-Queue (which can only land on `main`), should simply forbid it.
Comment 1 Radar WebKit Bug Importer 2023-04-17 16:48:16 PDT 
<rdar://problem/108166930>
Comment 2 Jonathan Bedard 2023-04-17 16:50:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12832
Comment 3 EWS 2023-04-18 13:51:18 PDT 
Committed 263093@main (5250da04ce61): <https://commits.webkit.org/263093@main>

Reviewed commits have been landed. Closing PR #12832 and removing active labels.