Bug 255618 - Add support for duplicate attributes to the HTML fast parser
Summary: Add support for duplicate attributes to the HTML fast parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-18 12:08 PDT by Chris Dumez
Modified: 2023-04-19 09:20 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-04-18 12:08:31 PDT
The HTML fast parser already had logic to detect duplicate attributes, so it was already doing most the work. However, when finding a duplicate, it would just abort and let the full HTML parser deal with the input string. It is not much more work to properly support duplicate attributes and it doesn't slow down the parser on Speedometer. As a result, I think we should add the functionality.
Comment 1 Chris Dumez 2023-04-18 12:11:53 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12878
Comment 2 EWS 2023-04-19 09:19:32 PDT
Committed 263136@main (55036f71e776): <https://commits.webkit.org/263136@main>

Reviewed commits have been landed. Closing PR #12878 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-19 09:20:21 PDT
<rdar://problem/108264432>