Bug 255677 - [GPU Process] (REGRESSION 262607@main): Copy pixels of CGImage only if it is not a sub-image
Summary: [GPU Process] (REGRESSION 262607@main): Copy pixels of CGImage only if it is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-19 13:49 PDT by Said Abou-Hallawa
Modified: 2023-05-12 13:08 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-04-19 13:49:48 PDT 
If the calculation of sizeInBytes in ShareableBitmap::createFromImagePixels() does not match ShareableBitmapConfiguration::sizeInBytes(), we should not copy the pixels of this CGImage. Otherwise ShareableBitmapConfiguration will falsely describe the data in the SharedMemory. In this case we should fallback to ShareableBitmap::createFromImageDraw().
Comment 1 Said Abou-Hallawa 2023-04-19 13:50:50 PDT 
rdar://108072383
Comment 2 Said Abou-Hallawa 2023-04-19 14:07:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12933
Comment 3 EWS 2023-05-12 13:08:28 PDT 
Committed 264021@main (58702859275c): <https://commits.webkit.org/264021@main>

Reviewed commits have been landed. Closing PR #12933 and removing active labels.