Bug 255728 - Result of -webkit-line-clamp with block children may be incorrect during partial repint
Summary: Result of -webkit-line-clamp with block children may be incorrect during part...
Status: RESOLVED DUPLICATE of bug 255487
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 16
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-20 08:30 PDT by Ethan Wong
Modified: 2023-04-25 08:52 PDT (History)
4 users (show)

See Also:

Attachments
Test case to reproduce this issue (479 bytes, text/html)
2023-04-20 08:30 PDT, Ethan Wong 		no flags Details
Expected result for the test case (270 bytes, text/html)
2023-04-20 08:31 PDT, Ethan Wong 		no flags Details
Expected result for the test case (259 bytes, text/html)
2023-04-20 09:02 PDT, Ethan Wong 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ethan Wong 2023-04-20 08:30:19 PDT 
Created attachment 466009 [details]
Test case to reproduce this issue

visibleLineCountForLineClamp for individual child should be propagated to the parent layoutState.
Comment 1 Ethan Wong 2023-04-20 08:31:01 PDT 
Created attachment 466010 [details]
Expected result for the test case
Comment 2 Ethan Wong 2023-04-20 08:35:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12973
Comment 3 Ethan Wong 2023-04-20 09:02:12 PDT 
Created attachment 466011 [details]
Expected result for the test case
Comment 4 Ahmad Saleem 2023-04-25 03:41:02 PDT 
(In reply to Ethan Wong from comment #2)
> Pull request: https://github.com/WebKit/WebKit/pull/12973

This PR points to different bug?

PR just landed. Is this duplicate of bug 255487?
Comment 5 Ethan Wong 2023-04-25 05:42:50 PDT 
(In reply to Ahmad Saleem from comment #4)
> (In reply to Ethan Wong from comment #2)
> > Pull request: https://github.com/WebKit/WebKit/pull/12973
> 
> This PR points to different bug?
> 
> PR just landed. Is this duplicate of bug 255487?

The above PR should point to this bug. It seems the bug id is mistaken.

The two bugs results visually similar issue, could probably be merged together.
Comment 6 Ahmad Saleem 2023-04-25 06:13:49 PDT 
(In reply to Ethan Wong from comment #5)
> (In reply to Ahmad Saleem from comment #4)
> > (In reply to Ethan Wong from comment #2)
> > > Pull request: https://github.com/WebKit/WebKit/pull/12973
> > 
> > This PR points to different bug?
> > 
> > PR just landed. Is this duplicate of bug 255487?
> 
> The above PR should point to this bug. It seems the bug id is mistaken.
> 
> The two bugs results visually similar issue, could probably be merged
> together.

I asked @Alan for his comment on GitHub, once I get input, I will mark this as duplicate or I will revert your change so you can do PR with updated bug URL and then I will push it to main. Again - it is depending on Alan's response. :-)

For Reference - https://github.com/WebKit/WebKit/pull/12973#issuecomment-1521570408
Comment 7 Ahmad Saleem 2023-04-25 08:52:37 PDT 
This landed in bug 255487 as:

Committed 263360@main (59088ba85057): <https://commits.webkit.org/263360@main>

Reviewed commits have been landed. Closing PR #12973 and removing active labels.

*** This bug has been marked as a duplicate of bug 255487 ***