Bug 255785 - Do not deref CreationData's buffer when Cairo font is destroyed.
Summary: Do not deref CreationData's buffer when Cairo font is destroyed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-21 06:49 PDT by Vitaly Dyackhov
Modified: 2023-04-21 12:44 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-04-21 06:49:24 PDT 
Since 263084@main `FontCustomPlatformData` takes `FontPlatformData::CreationData` instead of `FragmentedSharedBuffer`.
The buffer is now a reference counted field of `FontPlatformData::CreationData` struct and will be automatically dereferenced when `FontCustomPlatformData` is destroyed.
It is an error to manually dereference it using Cairo font destroy function.
Comment 1 Vitaly Dyackhov 2023-04-21 06:55:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13029
Comment 2 EWS 2023-04-21 12:44:52 PDT 
Committed 263258@main (dc4c470f9471): <https://commits.webkit.org/263258@main>

Reviewed commits have been landed. Closing PR #13029 and removing active labels.