WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
255829
Use Markable in NodeWithIndex instead of a separate boolean
https://bugs.webkit.org/show_bug.cgi?id=255829
Summary
Use Markable in NodeWithIndex instead of a separate boolean
Ahmad Saleem
Reported
2023-04-22 10:42:43 PDT
Hi Team, This is another potential merge from Blink (one of Chris's patch): Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/4534831b29f809b7b6c6a6b1e61d716c854035ca
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/dom/NodeWithIndex.h#38
Just wanted to raise to get whether we should merge this? Happy to do PR. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-04-29 10:43:22 PDT
<
rdar://problem/108699717
>
Ahmad Saleem
Comment 2
2024-05-18 07:09:30 PDT
PR attempt:
https://github.com/WebKit/WebKit/pull/13072
Feedback to use Markable<unsigned>. Still need to learn it. :-)
Anne van Kesteren
Comment 3
2024-05-24 08:12:24 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29055
EWS
Comment 4
2024-05-24 22:48:57 PDT
Committed
279311@main
(c6158e01cbd3): <
https://commits.webkit.org/279311@main
> Reviewed commits have been landed. Closing PR #29055 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug