Bug 255829 - Use Markable in NodeWithIndex instead of a separate boolean
Summary: Use Markable in NodeWithIndex instead of a separate boolean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anne van Kesteren
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-22 10:42 PDT by Ahmad Saleem
Modified: 2024-05-24 22:48 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-04-22 10:42:43 PDT 
Hi Team,

This is another potential merge from Blink (one of Chris's patch):

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/4534831b29f809b7b6c6a6b1e61d716c854035ca

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/NodeWithIndex.h#38

Just wanted to raise to get whether we should merge this? Happy to do PR.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-04-29 10:43:22 PDT 
<rdar://problem/108699717>
Comment 2 Ahmad Saleem 2024-05-18 07:09:30 PDT 
PR attempt: https://github.com/WebKit/WebKit/pull/13072

Feedback to use Markable<unsigned>.

Still need to learn it. :-)
Comment 3 Anne van Kesteren 2024-05-24 08:12:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29055
Comment 4 EWS 2024-05-24 22:48:57 PDT 
Committed 279311@main (c6158e01cbd3): <https://commits.webkit.org/279311@main>

Reviewed commits have been landed. Closing PR #29055 and removing active labels.